Skip to content

fix: Modulus on decimal data type mismatch - #2922

Merged
andygrove merged 10 commits into
apache:mainfrom
andygrove:test-decimal
Dec 17, 2025
Merged

andygrove merged 10 commits into
apache:mainfrom
andygrove:test-decimal

Conversation

@andygrove

@andygrove andygrove commented Dec 16, 2025 •

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #2911

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@andygrove andygrove changed the title ignore ignore: investigating a test failure Dec 16, 2025
@codecov-commenter

codecov-commenter commented Dec 16, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.41%. Comparing base (f09f8af) to head (1bcd039).
⚠️ Report is 771 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2922      +/-   ##
============================================
+ Coverage     56.12%   59.41%   +3.28%     
- Complexity      976     1379     +403     
============================================
  Files           119      167      +48     
  Lines         11743    15353    +3610     
  Branches       2251     2548     +297     
============================================
+ Hits           6591     9122    +2531     
- Misses         4012     4945     +933     
- Partials       1140     1286     +146     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove

Copy link
Copy Markdown
Member Author

This branch fails locally for me:

mvn test -DwildcardSuites="org.apache.comet.CometExpressionSuite"
- Decimal random number tests repro *** FAILED *** (4 seconds, 761 milliseconds)
  org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1.0 (TID 1) (woody.lan executor driver): org.apache.comet.CometNativeException: Function 'spark_modulo' returned value of type 'Decimal256(33, 29)' while the following type was promised at planning time and expected: 'Decimal128(33, 29)'.
This issue was likely caused by a bug in DataFusion's code. Please help us to resolve this by filing a bug report in our issue tracker: https://github.com/apache/datafusion/issues

@andygrove andygrove changed the title ignore: investigating a test failure chore: Attempting to reproduce a test failure that I see locally Dec 16, 2025
@andygrove andygrove changed the title chore: Attempting to reproduce a test failure that I see locally fix: Modulus on decimal data type mismatch Dec 16, 2025
@andygrove
andygrove marked this pull request as ready for review December 16, 2025 23:39
@coderfender

Copy link
Copy Markdown
Contributor

@rishvin , since they worked on the initial feature

@snmvaughan snmvaughan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andygrove
andygrove merged commit b51a65d into apache:main Dec 17, 2025
113 checks passed
@andygrove
andygrove deleted the test-decimal branch December 17, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function 'spark_modulo' returned value of type 'Decimal256(29, 28)' ... expected: 'Decimal128(29, 28)'

5 participants